Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 744753002: Reland of 'Migrate device utils WriteFile to AdbWrapper' (Closed)

Created:
6 years, 1 month ago by perezju
Modified:
6 years, 1 month ago
Reviewers:
jbudorick, Sami
CC:
chromium-reviews, klundberg+watch_chromium.org, telemetry+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland of 'Migrate device utils WriteFile to AdbWrapper' This is a reland of https://codereview.chromium.org/715853002/ There are no changes, but the last attempt triggered some silent exit code errors which have now been fixed by https://codereview.chromium.org/732473003/ This CL provides a more robust and efficient implementation of WriteFile, also integrating the functionality of the (now removed) WriteTextFile. BUG=267773 Committed: https://crrev.com/60e45a48a3966cb4e0a64d7f8de6f390cd8100f7 Cr-Commit-Position: refs/heads/master@{#305040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -168 lines) Patch
M build/android/pylib/device/commands/install_commands.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/device/device_utils.py View 4 chunks +28 lines, -38 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 4 chunks +70 lines, -124 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
perezju
No changes from previous CL, hopefully should work now.
6 years, 1 month ago (2014-11-20 16:34:06 UTC) #2
Sami
Great, lgtm.
6 years, 1 month ago (2014-11-20 16:47:50 UTC) #3
jbudorick
lgtm
6 years, 1 month ago (2014-11-20 16:50:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744753002/1
6 years, 1 month ago (2014-11-20 17:06:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 18:33:33 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 18:34:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60e45a48a3966cb4e0a64d7f8de6f390cd8100f7
Cr-Commit-Position: refs/heads/master@{#305040}

Powered by Google App Engine
This is Rietveld 408576698