Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: extensions/renderer/runtime_custom_bindings.cc

Issue 744723002: remove some calls to to-be-deprecated v8::Value::To* functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/print_native_handler.cc ('k') | extensions/renderer/safe_builtins.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/runtime_custom_bindings.cc
diff --git a/extensions/renderer/runtime_custom_bindings.cc b/extensions/renderer/runtime_custom_bindings.cc
index fb6851e0f5392a82a0c02963478ccd1a79703480..3d1d3c24dd85a88c86a07a45b6c525a6ffa635d1 100644
--- a/extensions/renderer/runtime_custom_bindings.cc
+++ b/extensions/renderer/runtime_custom_bindings.cc
@@ -64,9 +64,9 @@ void RuntimeCustomBindings::OpenChannelToExtension(
if (extension && !extension->is_hosted_app())
info.source_id = extension->id();
- info.target_id = *v8::String::Utf8Value(args[0]->ToString());
+ info.target_id = *v8::String::Utf8Value(args[0]);
info.source_url = context()->GetURL();
- std::string channel_name = *v8::String::Utf8Value(args[1]->ToString());
+ std::string channel_name = *v8::String::Utf8Value(args[1]);
bool include_tls_channel_id =
args.Length() > 2 ? args[2]->BooleanValue() : false;
int port_id = -1;
@@ -100,8 +100,8 @@ void RuntimeCustomBindings::OpenChannelToNativeApp(
// The Javascript code should validate/fill the arguments.
CHECK(args.Length() >= 2 && args[0]->IsString() && args[1]->IsString());
- std::string extension_id = *v8::String::Utf8Value(args[0]->ToString());
- std::string native_app_name = *v8::String::Utf8Value(args[1]->ToString());
+ std::string extension_id = *v8::String::Utf8Value(args[0]);
+ std::string native_app_name = *v8::String::Utf8Value(args[1]);
int port_id = -1;
renderview->Send(new ExtensionHostMsg_OpenChannelToNativeApp(
@@ -130,7 +130,7 @@ void RuntimeCustomBindings::GetExtensionViews(
// all views for the current extension.
int browser_window_id = args[0]->Int32Value();
- std::string view_type_string = *v8::String::Utf8Value(args[1]->ToString());
+ std::string view_type_string = *v8::String::Utf8Value(args[1]);
StringToUpperASCII(&view_type_string);
// |view_type| == VIEW_TYPE_INVALID means getting any type of
// views.
« no previous file with comments | « extensions/renderer/print_native_handler.cc ('k') | extensions/renderer/safe_builtins.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698