Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: extensions/renderer/blob_native_handler.cc

Issue 744723002: remove some calls to to-be-deprecated v8::Value::To* functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/blob_native_handler.h" 5 #include "extensions/renderer/blob_native_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "third_party/WebKit/public/platform/WebCString.h" 8 #include "third_party/WebKit/public/platform/WebCString.h"
9 #include "third_party/WebKit/public/platform/WebURL.h" 9 #include "third_party/WebKit/public/platform/WebURL.h"
10 #include "third_party/WebKit/public/web/WebBlob.h" 10 #include "third_party/WebKit/public/web/WebBlob.h"
(...skipping 10 matching lines...) Expand all
21 21
22 // Take ownership of a Blob created on the browser process. Expects the Blob's 22 // Take ownership of a Blob created on the browser process. Expects the Blob's
23 // UUID, type, and size as arguments. Returns the Blob we just took to 23 // UUID, type, and size as arguments. Returns the Blob we just took to
24 // Javascript. The Blob reference in the browser process is dropped through 24 // Javascript. The Blob reference in the browser process is dropped through
25 // a separate flow to avoid leaking Blobs if the script context is destroyed. 25 // a separate flow to avoid leaking Blobs if the script context is destroyed.
26 void TakeBrowserProcessBlob(const v8::FunctionCallbackInfo<v8::Value>& args) { 26 void TakeBrowserProcessBlob(const v8::FunctionCallbackInfo<v8::Value>& args) {
27 DCHECK_EQ(3, args.Length()); 27 DCHECK_EQ(3, args.Length());
28 DCHECK(args[0]->IsString()); 28 DCHECK(args[0]->IsString());
29 DCHECK(args[1]->IsString()); 29 DCHECK(args[1]->IsString());
30 DCHECK(args[2]->IsInt32()); 30 DCHECK(args[2]->IsInt32());
31 std::string uuid(*v8::String::Utf8Value(args[0]->ToString())); 31 std::string uuid(*v8::String::Utf8Value(args[0]));
32 std::string type(*v8::String::Utf8Value(args[1]->ToString())); 32 std::string type(*v8::String::Utf8Value(args[1]));
33 blink::WebBlob blob = 33 blink::WebBlob blob =
34 blink::WebBlob::createFromUUID(blink::WebString::fromUTF8(uuid), 34 blink::WebBlob::createFromUUID(blink::WebString::fromUTF8(uuid),
35 blink::WebString::fromUTF8(type), 35 blink::WebString::fromUTF8(type),
36 args[2]->Int32Value()); 36 args[2]->Int32Value());
37 args.GetReturnValue().Set(blob.toV8Value(args.Holder(), args.GetIsolate())); 37 args.GetReturnValue().Set(blob.toV8Value(args.Holder(), args.GetIsolate()));
38 } 38 }
39 39
40 } // namespace 40 } // namespace
41 41
42 namespace extensions { 42 namespace extensions {
43 43
44 BlobNativeHandler::BlobNativeHandler(ScriptContext* context) 44 BlobNativeHandler::BlobNativeHandler(ScriptContext* context)
45 : ObjectBackedNativeHandler(context) { 45 : ObjectBackedNativeHandler(context) {
46 RouteFunction("GetBlobUuid", base::Bind(&GetBlobUuid)); 46 RouteFunction("GetBlobUuid", base::Bind(&GetBlobUuid));
47 RouteFunction("TakeBrowserProcessBlob", base::Bind(&TakeBrowserProcessBlob)); 47 RouteFunction("TakeBrowserProcessBlob", base::Bind(&TakeBrowserProcessBlob));
48 } 48 }
49 49
50 } // namespace extensions 50 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/renderer/binding_generating_native_handler.cc ('k') | extensions/renderer/document_custom_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698