tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py - Issue 744703003: Reduce DRP telemetry tests' dependence on net-internals#proxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

Issue 744703003: Reduce DRP telemetry tests' dependence on net-internals#proxy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py » ('j') | tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

index 1be3f9254c13ca578ffaa2bce8cd37407d31aafb..91e018050a874957e5fe3d526f64527fb5a0e6d0 100644

--- a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

@@ -310,6 +310,9 @@ class ChromeProxyHTTPToDirectFallback(ChromeProxyValidation):

'nonexistent.googlezip.net:80',

self._metrics.effective_proxies['fallback'],

self._metrics.effective_proxies['direct']]

+ # TODO(sclittle): Remove this dependency on net-internals#proxy once an

+ # alternative method of verifying that Chrome is on the fallback proxy

+ # exists.

self._metrics.VerifyProxyInfo(tab, proxies, proxies[:1])

def AddResults(self, tab, results):

« no previous file with comments | « no previous file | tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py » ('j') | tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py » ('J')