Reduce DRP telemetry tests' dependence on net-internals#proxy.

Reduce DRP telemetry tests' dependence on net-internals#proxy.

Reduce the data reduction proxy tests' dependence on
net-internals#proxy. After this change, the only tests that still depend
on net-internals#proxy are http_to_direct_fallback, fallback_viaheader,
fallback_probe, explicit_bypass. These tests, along with the
safebrowsing test, are the only ones that can't run against the
android-webview-shell yet.

BUG=440522
Committed: https://crrev.com/564149649d6323a3159c417c1c880fa889f210a5
Cr-Commit-Position: refs/heads/master@{#307940}

[sclittle, 2014-12-09 21:38:42]

sclittle@chromium.org changed reviewers:
+ bengr@chromium.org, bolian@chromium.org

[sclittle, 2014-12-09 21:38:42]

bengr, bolian: all

Thanks in advance

[bolian, 2014-12-09 22:06:14]

what will be alternative to get proxy info in the future?

https://codereview.chromium.org/744703003/diff/1/tools/chrome_proxy/integrati...
File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (left):

https://codereview.chromium.org/744703003/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:356:
self.VerifyAllProxiesBypassed(tab)
Not verifying this any more?

https://codereview.chromium.org/744703003/diff/1/tools/chrome_proxy/integrati...
File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right):

https://codereview.chromium.org/744703003/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:494:
results.current_page, 'bypass', 'count', bypass_count))
This result, 'bypass', does not match the func name xxxHTTPToDirectFallback.
Misplaced?

[sclittle, 2014-12-09 22:25:21]

https://codereview.chromium.org/744703003/diff/1/tools/chrome_proxy/integrati...
File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (left):

https://codereview.chromium.org/744703003/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:356:
self.VerifyAllProxiesBypassed(tab)
On 2014/12/09 22:06:14, bolian wrote:
> Not verifying this any more?

Not anymore. The only thing this call gains us here is to check how long the
proxy is bypassed for, so we can verify that the bypass is for 1-5 minutes. The
justification here is that this test doesn't really need to do that in order to
verify that bypass is working, since we already check that the responses don't
have the via headers.

https://codereview.chromium.org/744703003/diff/1/tools/chrome_proxy/integrati...
File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right):

https://codereview.chromium.org/744703003/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:494:
results.current_page, 'bypass', 'count', bypass_count))
On 2014/12/09 22:06:14, bolian wrote:
> This result, 'bypass', does not match the func name xxxHTTPToDirectFallback.
> Misplaced?

Should it match it? This result is the number of bypassed responses in this
test; other tests do this with stats like "eligible_responses" and
"resources_via_proxy". Isn't this string the name of the result statistic, and
not the name of the test?

[bolian, 2014-12-09 22:40:06]

lgtm

Do you have a plan for the alternative of getting proxy info?

[sclittle, 2014-12-09 22:44:33]

On 2014/12/09 22:40:06, bolian wrote:
> lgtm
> 
> Do you have a plan for the alternative of getting proxy info?

Probably some sort of test page or test response header that's attached to test
page responses that when fetched through the proxy indicates whether the HTTPS
or HTTP proxy was used. I'm not sure how we could do that for the dev proxy
though, since in that case the primary proxy is an HTTP proxy.

[bengr, 2014-12-10 21:27:13]

lgtm. Thanks for doing this!

[sclittle, 2014-12-10 21:35:06]

The CQ bit was checked by sclittle@chromium.org

[commit-bot: I haz the power, 2014-12-10 21:36:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/744703003/1

[commit-bot: I haz the power, 2014-12-10 21:40:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-10 21:40:36]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sclittle, 2014-12-11 18:20:52]

The CQ bit was checked by sclittle@chromium.org

[commit-bot: I haz the power, 2014-12-11 18:21:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/744703003/20001

[commit-bot: I haz the power, 2014-12-11 18:54:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-11 18:55:31]

Patchset 2 (id:??) landed as
https://crrev.com/564149649d6323a3159c417c1c880fa889f210a5
Cr-Commit-Position: refs/heads/master@{#307940}