Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: content/browser/devtools/embedded_worker_devtools_agent_host.cc

Issue 744683002: [DevTools] Used generated Worker.disconnectedFromWorker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/embedded_worker_devtools_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/embedded_worker_devtools_agent_host.cc
diff --git a/content/browser/devtools/embedded_worker_devtools_agent_host.cc b/content/browser/devtools/embedded_worker_devtools_agent_host.cc
index dede4d93d8a23b0a77bb0b50b37fc5f04c04bebd..25700d09b4899890a7990b5eed2108853b36560e 100644
--- a/content/browser/devtools/embedded_worker_devtools_agent_host.cc
+++ b/content/browser/devtools/embedded_worker_devtools_agent_host.cc
@@ -5,8 +5,7 @@
#include "content/browser/devtools/embedded_worker_devtools_agent_host.h"
#include "base/strings/utf_string_conversions.h"
-#include "content/browser/devtools/devtools_protocol.h"
-#include "content/browser/devtools/devtools_protocol_constants.h"
+#include "content/browser/devtools/protocol/devtools_protocol_handler_impl.h"
#include "content/browser/service_worker/service_worker_context_core.h"
#include "content/browser/service_worker/service_worker_version.h"
#include "content/browser/shared_worker/shared_worker_service_impl.h"
@@ -171,10 +170,12 @@ void EmbeddedWorkerDevToolsAgentHost::WorkerDestroyed() {
if (state_ == WORKER_INSPECTED) {
DCHECK(IsAttached());
// Client host is debugging this worker agent host.
- std::string notification =
- DevToolsProtocol::CreateNotification(
- devtools::Worker::disconnectedFromWorker::kName, NULL)->Serialize();
- SendMessageToClient(notification);
+ base::Callback<void(const std::string&)> raw_message_callback(
+ base::Bind(&EmbeddedWorkerDevToolsAgentHost::SendMessageToClient,
+ base::Unretained(this)));
+ devtools::worker::Client worker(raw_message_callback);
+ worker.DisconnectedFromWorker(
+ devtools::worker::DisconnectedFromWorkerParams::Create());
DetachFromWorker();
}
state_ = WORKER_TERMINATED;
« no previous file with comments | « no previous file | content/browser/devtools/embedded_worker_devtools_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698