Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 744683002: [DevTools] Used generated Worker.disconnectedFromWorker (Closed)

Created:
6 years, 1 month ago by vkuzkokov
Modified:
6 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Used generated Worker.disconnectedFromWorker BUG=405566 Committed: https://crrev.com/6dbe8de85aaa525deadae67d60542adda57ecc80 Cr-Commit-Position: refs/heads/master@{#305027}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M content/browser/devtools/embedded_worker_devtools_agent_host.cc View 1 2 chunks +7 lines, -6 lines 0 comments Download
M content/browser/devtools/embedded_worker_devtools_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
vkuzkokov
6 years, 1 month ago (2014-11-20 14:11:57 UTC) #2
dgozman
https://codereview.chromium.org/744683002/diff/1/content/browser/devtools/embedded_worker_devtools_agent_host.cc File content/browser/devtools/embedded_worker_devtools_agent_host.cc (right): https://codereview.chromium.org/744683002/diff/1/content/browser/devtools/embedded_worker_devtools_agent_host.cc#newcode181 content/browser/devtools/embedded_worker_devtools_agent_host.cc:181: worker_domain_client_->DisconnectedFromWorker( Let's create worker domain client right here to ...
6 years, 1 month ago (2014-11-20 14:38:07 UTC) #3
vkuzkokov
https://codereview.chromium.org/744683002/diff/1/content/browser/devtools/embedded_worker_devtools_agent_host.cc File content/browser/devtools/embedded_worker_devtools_agent_host.cc (right): https://codereview.chromium.org/744683002/diff/1/content/browser/devtools/embedded_worker_devtools_agent_host.cc#newcode181 content/browser/devtools/embedded_worker_devtools_agent_host.cc:181: worker_domain_client_->DisconnectedFromWorker( On 2014/11/20 14:38:07, dgozman wrote: > Let's create ...
6 years, 1 month ago (2014-11-20 15:05:07 UTC) #4
dgozman
lgtm
6 years, 1 month ago (2014-11-20 15:10:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744683002/20001
6 years, 1 month ago (2014-11-20 15:21:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-20 17:33:29 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 17:34:10 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/6dbe8de85aaa525deadae67d60542adda57ecc80
Cr-Commit-Position: refs/heads/master@{#305027}

Powered by Google App Engine
This is Rietveld 408576698