Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: extensions/browser/app_window/app_window.cc

Issue 744663002: Fix WeakPtrFactory member ordering in extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/app_window/app_window.cc
diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc
index 1f49e3aef7733788c14d2259cee3838c4337c147..cf120513c3e5cb89e24efca7f7d3cef708220427 100644
--- a/extensions/browser/app_window/app_window.cc
+++ b/extensions/browser/app_window/app_window.cc
@@ -227,22 +227,14 @@ gfx::Size AppWindow::CreateParams::GetWindowMaximumSize(
// AppWindow
-AppWindow::AppWindow(BrowserContext* context,
- AppDelegate* app_delegate,
- const Extension* extension)
- : browser_context_(context),
- extension_id_(extension->id()),
- window_type_(WINDOW_TYPE_DEFAULT),
- app_delegate_(app_delegate),
- image_loader_ptr_factory_(this),
- fullscreen_types_(FULLSCREEN_TYPE_NONE),
- show_on_first_paint_(false),
- first_paint_complete_(false),
- has_been_shown_(false),
- can_send_events_(false),
- is_hidden_(false),
- cached_always_on_top_(false),
- requested_alpha_enabled_(false) {
+AppWindow::AppWindow(BrowserContext *context, AppDelegate *app_delegate,
not at google - send to devlin 2014/11/20 15:30:30 Same?
MRV 2014/11/21 11:12:39 I'll change as original style.
+ const Extension *extension)
+ : browser_context_(context), extension_id_(extension->id()),
+ window_type_(WINDOW_TYPE_DEFAULT), app_delegate_(app_delegate),
+ fullscreen_types_(FULLSCREEN_TYPE_NONE), show_on_first_paint_(false),
+ first_paint_complete_(false), has_been_shown_(false),
+ can_send_events_(false), is_hidden_(false), cached_always_on_top_(false),
+ requested_alpha_enabled_(false), image_loader_ptr_factory_(this) {
ExtensionsBrowserClient* client = ExtensionsBrowserClient::Get();
CHECK(!client->IsGuestSession(context) || context->IsOffTheRecord())
<< "Only off the record window may be opened in the guest mode.";

Powered by Google App Engine
This is Rietveld 408576698