content/renderer/render_view_impl.cc - Issue 744653002: Ignore DevTools messages from the old inspected RVH after navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 744653002: Ignore DevTools messages from the old inspected RVH after navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use WebContents instead of RVH when creating DTFH Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/devtools/devtools_agent.cc ('K') | « content/renderer/devtools/devtools_client.cc ('k') | content/shell/browser/shell_devtools_frontend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index ed8b491410f443e2e56d58ded84a3b1658ae2210..3ccc92b64565ff42cd594df694c2819a84f1b4c7 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -805,7 +805,7 @@ void RenderViewImpl::Initialize(RenderViewImplParams* params) {

// The next group of objects all implement RenderViewObserver, so are deleted

// along with the RenderView automatically.

- devtools_agent_ = new DevToolsAgent(this);

+ devtools_agent_ = new DevToolsAgent(main_render_frame_.get());

if (RenderWidgetCompositor* rwc = compositor()) {

webview()->devToolsAgent()->setLayerTreeId(rwc->GetLayerTreeId());

}