Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 744653002: Ignore DevTools messages from the old inspected RVH after navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comment Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/devtools_frontend_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_ui_bindings.cc
diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc
index 3abcde8a4f0500f0069617ae5f8153e30bcd5d86..c3bf082da359ea2051a745744cc27436ae21fa8c 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.cc
+++ b/chrome/browser/devtools/devtools_ui_bindings.cc
@@ -281,10 +281,11 @@ void DevToolsUIBindings::FrontendWebContentsObserver::RenderProcessGone(
void DevToolsUIBindings::FrontendWebContentsObserver::
AboutToNavigateRenderFrame(content::RenderFrameHost* render_frame_host) {
- // TODO(creis): Create should be refactored to operate on RenderFrameHosts.
+ if (render_frame_host->GetParent())
+ return;
devtools_bindings_->frontend_host_.reset(
- content::DevToolsFrontendHost::Create(
- render_frame_host->GetRenderViewHost(), devtools_bindings_));
+ content::DevToolsFrontendHost::Create(devtools_bindings_->web_contents(),
+ devtools_bindings_));
}
void DevToolsUIBindings::FrontendWebContentsObserver::
@@ -369,8 +370,7 @@ DevToolsUIBindings::DevToolsUIBindings(content::WebContents* web_contents)
DevToolsEmbedderMessageDispatcher::createForDevToolsFrontend(this));
frontend_host_.reset(
- content::DevToolsFrontendHost::Create(
- web_contents_->GetRenderViewHost(), this));
+ content::DevToolsFrontendHost::Create(web_contents_, this));
}
DevToolsUIBindings::~DevToolsUIBindings() {
« no previous file with comments | « no previous file | content/browser/devtools/devtools_frontend_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698