content/public/browser/devtools_frontend_host.h - Issue 744653002: Ignore DevTools messages from the old inspected RVH after navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/devtools_frontend_host.h

Issue 744653002: Ignore DevTools messages from the old inspected RVH after navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/devtools/devtools_frontend_host_impl.cc ('K') | « content/browser/devtools/render_view_devtools_agent_host.cc ('k') | content/renderer/devtools/devtools_agent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/devtools_frontend_host.h

diff --git a/content/public/browser/devtools_frontend_host.h b/content/public/browser/devtools_frontend_host.h

index 24c50f51e07b1e61ac22fb15c40db11c36d65f22..d1b01fe537a1c5d2f196483130520f5ee8c6d665 100644

--- a/content/public/browser/devtools_frontend_host.h

+++ b/content/public/browser/devtools_frontend_host.h

@@ -11,7 +11,7 @@

namespace content {

-class RenderViewHost;

+class WebContents;

// This class dispatches messages between DevTools frontend and Delegate

// which is implemented by the embedder.

@@ -35,10 +35,11 @@ class DevToolsFrontendHost {

const std::string& message) = 0;

};

- // Creates a new DevToolsFrontendHost for RenderViewHost where DevTools

+ // Creates a new DevToolsFrontendHost for WebContents where DevTools

// frontend is loaded.

CONTENT_EXPORT static DevToolsFrontendHost* Create(

- RenderViewHost* frontend_rvh, Delegate* delegate);

+ WebContents* frontend_web_contents,

+ Delegate* delegate);

CONTENT_EXPORT virtual ~DevToolsFrontendHost() {}

};