content/browser/devtools/devtools_frontend_host_impl.h - Issue 744653002: Ignore DevTools messages from the old inspected RVH after navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_frontend_host_impl.h

Issue 744653002: Ignore DevTools messages from the old inspected RVH after navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_ui_bindings.cc ('k') | content/browser/devtools/devtools_frontend_host_impl.cc » ('j') | content/browser/devtools/devtools_frontend_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/devtools_frontend_host_impl.h

diff --git a/content/browser/devtools/devtools_frontend_host_impl.h b/content/browser/devtools/devtools_frontend_host_impl.h

index 98b907497a1fb34920755539568cc02f0ec86da5..81f01f04bc45151bbf13fd07e7951f46a7b3da85 100644

--- a/content/browser/devtools/devtools_frontend_host_impl.h

+++ b/content/browser/devtools/devtools_frontend_host_impl.h

@@ -13,13 +13,14 @@ namespace content {

class DevToolsFrontendHostImpl : public DevToolsFrontendHost,

public WebContentsObserver {

public:

- DevToolsFrontendHostImpl(RenderViewHost* frontend_rvh,

+ DevToolsFrontendHostImpl(WebContents* frontend_web_contents,

DevToolsFrontendHost::Delegate* delegate);

~DevToolsFrontendHostImpl() override;

private:

// WebContentsObserver overrides.

- bool OnMessageReceived(const IPC::Message& message) override;

+ bool OnMessageReceived(const IPC::Message& message,

+ RenderFrameHost* render_frame_host) override;

void OnDispatchOnInspectorBackend(const std::string& message);

void OnDispatchOnEmbedder(const std::string& message);