Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: content/browser/devtools/devtools_frontend_host_impl.cc

Issue 744653002: Ignore DevTools messages from the old inspected RVH after navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use WebContents instead of RVH when creating DTFH Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/devtools/devtools_frontend_host_impl.h" 5 #include "content/browser/devtools/devtools_frontend_host_impl.h"
6 6
7 #include "content/common/devtools_messages.h" 7 #include "content/common/devtools_messages.h"
8 #include "content/public/browser/navigation_entry.h" 8 #include "content/public/browser/navigation_entry.h"
9 #include "content/public/browser/render_frame_host.h"
9 #include "content/public/browser/render_view_host.h" 10 #include "content/public/browser/render_view_host.h"
dgozman 2014/11/24 13:32:13 nit: this is not used anymore.
yurys 2014/11/24 14:08:54 Done.
10 #include "content/public/browser/web_contents.h" 11 #include "content/public/browser/web_contents.h"
11 12
12 namespace content { 13 namespace content {
13 14
14 // static 15 // static
15 DevToolsFrontendHost* DevToolsFrontendHost::Create( 16 DevToolsFrontendHost* DevToolsFrontendHost::Create(
16 RenderViewHost* frontend_rvh, 17 WebContents* frontend_web_contents,
17 DevToolsFrontendHost::Delegate* delegate) { 18 DevToolsFrontendHost::Delegate* delegate) {
18 return new DevToolsFrontendHostImpl(frontend_rvh, delegate); 19 return new DevToolsFrontendHostImpl(frontend_web_contents, delegate);
19 } 20 }
20 21
21 DevToolsFrontendHostImpl::DevToolsFrontendHostImpl( 22 DevToolsFrontendHostImpl::DevToolsFrontendHostImpl(
22 RenderViewHost* frontend_rvh, 23 WebContents* frontend_web_contents,
23 DevToolsFrontendHost::Delegate* delegate) 24 DevToolsFrontendHost::Delegate* delegate)
24 : WebContentsObserver(WebContents::FromRenderViewHost(frontend_rvh)), 25 : WebContentsObserver(frontend_web_contents), delegate_(delegate) {
25 delegate_(delegate) { 26 RenderFrameHost* main_frame_host = web_contents()->GetMainFrame();
26 frontend_rvh->Send(new DevToolsMsg_SetupDevToolsClient( 27 main_frame_host->Send(
27 frontend_rvh->GetRoutingID())); 28 new DevToolsMsg_SetupDevToolsClient(main_frame_host->GetRoutingID()));
28 } 29 }
29 30
30 DevToolsFrontendHostImpl::~DevToolsFrontendHostImpl() { 31 DevToolsFrontendHostImpl::~DevToolsFrontendHostImpl() {
31 } 32 }
32 33
33 bool DevToolsFrontendHostImpl::OnMessageReceived( 34 bool DevToolsFrontendHostImpl::OnMessageReceived(
34 const IPC::Message& message) { 35 const IPC::Message& message,
36 RenderFrameHost* render_frame_host) {
35 bool handled = true; 37 bool handled = true;
36 IPC_BEGIN_MESSAGE_MAP(DevToolsFrontendHostImpl, message) 38 IPC_BEGIN_MESSAGE_MAP(DevToolsFrontendHostImpl, message)
37 IPC_MESSAGE_HANDLER(DevToolsAgentMsg_DispatchOnInspectorBackend, 39 IPC_MESSAGE_HANDLER(DevToolsAgentMsg_DispatchOnInspectorBackend,
38 OnDispatchOnInspectorBackend) 40 OnDispatchOnInspectorBackend)
39 IPC_MESSAGE_HANDLER(DevToolsHostMsg_DispatchOnEmbedder, 41 IPC_MESSAGE_HANDLER(DevToolsHostMsg_DispatchOnEmbedder,
40 OnDispatchOnEmbedder) 42 OnDispatchOnEmbedder)
41 IPC_MESSAGE_UNHANDLED(handled = false) 43 IPC_MESSAGE_UNHANDLED(handled = false)
42 IPC_END_MESSAGE_MAP() 44 IPC_END_MESSAGE_MAP()
43 return handled; 45 return handled;
44 } 46 }
45 47
46 void DevToolsFrontendHostImpl::OnDispatchOnInspectorBackend( 48 void DevToolsFrontendHostImpl::OnDispatchOnInspectorBackend(
47 const std::string& message) { 49 const std::string& message) {
48 delegate_->HandleMessageFromDevToolsFrontendToBackend(message); 50 delegate_->HandleMessageFromDevToolsFrontendToBackend(message);
49 } 51 }
50 52
51 void DevToolsFrontendHostImpl::OnDispatchOnEmbedder( 53 void DevToolsFrontendHostImpl::OnDispatchOnEmbedder(
52 const std::string& message) { 54 const std::string& message) {
53 delegate_->HandleMessageFromDevToolsFrontend(message); 55 delegate_->HandleMessageFromDevToolsFrontend(message);
54 } 56 }
55 57
56 } // namespace content 58 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698