Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Side by Side Diff: content/browser/devtools/render_view_devtools_agent_host.h

Issue 744653002: Ignore DevTools messages from the old inspected RVH after navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DEVTOOLS_RENDER_VIEW_DEVTOOLS_AGENT_HOST_H_ 5 #ifndef CONTENT_BROWSER_DEVTOOLS_RENDER_VIEW_DEVTOOLS_AGENT_HOST_H_
6 #define CONTENT_BROWSER_DEVTOOLS_RENDER_VIEW_DEVTOOLS_AGENT_HOST_H_ 6 #define CONTENT_BROWSER_DEVTOOLS_RENDER_VIEW_DEVTOOLS_AGENT_HOST_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 29 matching lines...) Expand all
40 namespace tracing { class TracingHandler; } 40 namespace tracing { class TracingHandler; }
41 } 41 }
42 42
43 class CONTENT_EXPORT RenderViewDevToolsAgentHost 43 class CONTENT_EXPORT RenderViewDevToolsAgentHost
44 : public IPCDevToolsAgentHost, 44 : public IPCDevToolsAgentHost,
45 private WebContentsObserver, 45 private WebContentsObserver,
46 public NotificationObserver { 46 public NotificationObserver {
47 public: 47 public:
48 static void OnCancelPendingNavigation(RenderViewHost* pending, 48 static void OnCancelPendingNavigation(RenderViewHost* pending,
49 RenderViewHost* current); 49 RenderViewHost* current);
50 static bool DispatchIPCMessage(RenderViewHost* source,
51 const IPC::Message& message);
50 52
51 RenderViewDevToolsAgentHost(RenderViewHost*); 53 RenderViewDevToolsAgentHost(RenderViewHost*);
52 54
53 void SynchronousSwapCompositorFrame( 55 void SynchronousSwapCompositorFrame(
54 const cc::CompositorFrameMetadata& frame_metadata); 56 const cc::CompositorFrameMetadata& frame_metadata);
55 57
56 // DevTooolsAgentHost overrides. 58 // DevTooolsAgentHost overrides.
57 void DisconnectWebContents() override; 59 void DisconnectWebContents() override;
58 void ConnectWebContents(WebContents* web_contents) override; 60 void ConnectWebContents(WebContents* web_contents) override;
59 BrowserContext* GetBrowserContext() override; 61 BrowserContext* GetBrowserContext() override;
(...skipping 13 matching lines...) Expand all
73 void SendMessageToAgent(IPC::Message* msg) override; 75 void SendMessageToAgent(IPC::Message* msg) override;
74 void OnClientAttached() override; 76 void OnClientAttached() override;
75 void OnClientDetached() override; 77 void OnClientDetached() override;
76 78
77 // WebContentsObserver overrides. 79 // WebContentsObserver overrides.
78 void AboutToNavigateRenderFrame(RenderFrameHost* render_frame_host) override; 80 void AboutToNavigateRenderFrame(RenderFrameHost* render_frame_host) override;
79 void RenderViewHostChanged(RenderViewHost* old_host, 81 void RenderViewHostChanged(RenderViewHost* old_host,
80 RenderViewHost* new_host) override; 82 RenderViewHost* new_host) override;
81 void RenderViewDeleted(RenderViewHost* rvh) override; 83 void RenderViewDeleted(RenderViewHost* rvh) override;
82 void RenderProcessGone(base::TerminationStatus status) override; 84 void RenderProcessGone(base::TerminationStatus status) override;
83 bool OnMessageReceived(const IPC::Message& message,
84 RenderFrameHost* render_frame_host) override;
85 bool OnMessageReceived(const IPC::Message& message) override;
86 void DidAttachInterstitialPage() override; 85 void DidAttachInterstitialPage() override;
87 void DidDetachInterstitialPage() override; 86 void DidDetachInterstitialPage() override;
88 void TitleWasSet(NavigationEntry* entry, bool explicit_set) override; 87 void TitleWasSet(NavigationEntry* entry, bool explicit_set) override;
89 void NavigationEntryCommitted( 88 void NavigationEntryCommitted(
90 const LoadCommittedDetails& load_details) override; 89 const LoadCommittedDetails& load_details) override;
91 90
92 // NotificationObserver overrides: 91 // NotificationObserver overrides:
93 void Observe(int type, 92 void Observe(int type,
94 const NotificationSource& source, 93 const NotificationSource& source,
95 const NotificationDetails& details) override; 94 const NotificationDetails& details) override;
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 std::string state_; 130 std::string state_;
132 NotificationRegistrar registrar_; 131 NotificationRegistrar registrar_;
133 bool reattaching_; 132 bool reattaching_;
134 133
135 DISALLOW_COPY_AND_ASSIGN(RenderViewDevToolsAgentHost); 134 DISALLOW_COPY_AND_ASSIGN(RenderViewDevToolsAgentHost);
136 }; 135 };
137 136
138 } // namespace content 137 } // namespace content
139 138
140 #endif // CONTENT_BROWSER_DEVTOOLS_RENDER_VIEW_DEVTOOLS_AGENT_HOST_H_ 139 #endif // CONTENT_BROWSER_DEVTOOLS_RENDER_VIEW_DEVTOOLS_AGENT_HOST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698