Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Side by Side Diff: content/renderer/devtools/devtools_client.cc

Issue 744653002: Ignore DevTools messages from the old inspected RVH after navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comment Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/devtools/devtools_client.h ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/devtools/devtools_client.h" 5 #include "content/renderer/devtools/devtools_client.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "content/common/devtools_messages.h" 10 #include "content/common/devtools_messages.h"
11 #include "content/public/common/content_switches.h" 11 #include "content/public/common/content_switches.h"
12 #include "content/public/common/url_constants.h" 12 #include "content/public/common/url_constants.h"
13 #include "content/renderer/render_thread_impl.h" 13 #include "content/renderer/render_thread_impl.h"
14 #include "content/renderer/render_view_impl.h" 14 #include "content/renderer/render_view_impl.h"
15 #include "third_party/WebKit/public/platform/WebFloatPoint.h" 15 #include "third_party/WebKit/public/platform/WebFloatPoint.h"
16 #include "third_party/WebKit/public/platform/WebString.h" 16 #include "third_party/WebKit/public/platform/WebString.h"
17 #include "third_party/WebKit/public/web/WebDevToolsFrontend.h" 17 #include "third_party/WebKit/public/web/WebDevToolsFrontend.h"
18 #include "ui/base/ui_base_switches.h" 18 #include "ui/base/ui_base_switches.h"
19 19
20 using blink::WebDevToolsFrontend; 20 using blink::WebDevToolsFrontend;
21 using blink::WebString; 21 using blink::WebString;
22 22
23 namespace content { 23 namespace content {
24 24
25 DevToolsClient::DevToolsClient(RenderViewImpl* render_view) 25 DevToolsClient::DevToolsClient(RenderFrame* main_render_frame)
26 : RenderViewObserver(render_view) { 26 : RenderFrameObserver(main_render_frame) {
27 const CommandLine& command_line = *CommandLine::ForCurrentProcess(); 27 const CommandLine& command_line = *CommandLine::ForCurrentProcess();
28 web_tools_frontend_.reset( 28 web_tools_frontend_.reset(WebDevToolsFrontend::create(
29 WebDevToolsFrontend::create( 29 main_render_frame->GetRenderView()->GetWebView(), this,
30 render_view->webview(), 30 base::ASCIIToUTF16(command_line.GetSwitchValueASCII(switches::kLang))));
31 this,
32 base::ASCIIToUTF16(
33 command_line.GetSwitchValueASCII(switches::kLang))));
34 } 31 }
35 32
36 DevToolsClient::~DevToolsClient() { 33 DevToolsClient::~DevToolsClient() {
37 } 34 }
38 35
39 void DevToolsClient::sendMessageToBackend(const WebString& message) { 36 void DevToolsClient::sendMessageToBackend(const WebString& message) {
40 Send(new DevToolsAgentMsg_DispatchOnInspectorBackend(routing_id(), 37 Send(new DevToolsAgentMsg_DispatchOnInspectorBackend(routing_id(),
41 message.utf8())); 38 message.utf8()));
42 } 39 }
43 40
44 void DevToolsClient::sendMessageToEmbedder(const WebString& message) { 41 void DevToolsClient::sendMessageToEmbedder(const WebString& message) {
45 Send(new DevToolsHostMsg_DispatchOnEmbedder(routing_id(), 42 Send(new DevToolsHostMsg_DispatchOnEmbedder(routing_id(),
46 message.utf8())); 43 message.utf8()));
47 } 44 }
48 45
49 bool DevToolsClient::isUnderTest() { 46 bool DevToolsClient::isUnderTest() {
50 return RenderThreadImpl::current()->layout_test_mode(); 47 return RenderThreadImpl::current()->layout_test_mode();
51 } 48 }
52 49
53 } // namespace content 50 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/devtools/devtools_client.h ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698