Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: content/browser/devtools/render_view_devtools_agent_host.h

Issue 744653002: Ignore DevTools messages from the old inspected RVH after navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comment Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DEVTOOLS_RENDER_VIEW_DEVTOOLS_AGENT_HOST_H_ 5 #ifndef CONTENT_BROWSER_DEVTOOLS_RENDER_VIEW_DEVTOOLS_AGENT_HOST_H_
6 #define CONTENT_BROWSER_DEVTOOLS_RENDER_VIEW_DEVTOOLS_AGENT_HOST_H_ 6 #define CONTENT_BROWSER_DEVTOOLS_RENDER_VIEW_DEVTOOLS_AGENT_HOST_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 void OnClientDetached() override; 76 void OnClientDetached() override;
77 77
78 // WebContentsObserver overrides. 78 // WebContentsObserver overrides.
79 void AboutToNavigateRenderFrame(RenderFrameHost* render_frame_host) override; 79 void AboutToNavigateRenderFrame(RenderFrameHost* render_frame_host) override;
80 void RenderViewHostChanged(RenderViewHost* old_host, 80 void RenderViewHostChanged(RenderViewHost* old_host,
81 RenderViewHost* new_host) override; 81 RenderViewHost* new_host) override;
82 void RenderViewDeleted(RenderViewHost* rvh) override; 82 void RenderViewDeleted(RenderViewHost* rvh) override;
83 void RenderProcessGone(base::TerminationStatus status) override; 83 void RenderProcessGone(base::TerminationStatus status) override;
84 bool OnMessageReceived(const IPC::Message& message, 84 bool OnMessageReceived(const IPC::Message& message,
85 RenderFrameHost* render_frame_host) override; 85 RenderFrameHost* render_frame_host) override;
86 bool OnMessageReceived(const IPC::Message& message) override;
87 void DidAttachInterstitialPage() override; 86 void DidAttachInterstitialPage() override;
88 void DidDetachInterstitialPage() override; 87 void DidDetachInterstitialPage() override;
89 void TitleWasSet(NavigationEntry* entry, bool explicit_set) override; 88 void TitleWasSet(NavigationEntry* entry, bool explicit_set) override;
90 void NavigationEntryCommitted( 89 void NavigationEntryCommitted(
91 const LoadCommittedDetails& load_details) override; 90 const LoadCommittedDetails& load_details) override;
92 91
93 // NotificationObserver overrides: 92 // NotificationObserver overrides:
94 void Observe(int type, 93 void Observe(int type,
95 const NotificationSource& source, 94 const NotificationSource& source,
96 const NotificationDetails& details) override; 95 const NotificationDetails& details) override;
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 std::string state_; 132 std::string state_;
134 NotificationRegistrar registrar_; 133 NotificationRegistrar registrar_;
135 bool reattaching_; 134 bool reattaching_;
136 135
137 DISALLOW_COPY_AND_ASSIGN(RenderViewDevToolsAgentHost); 136 DISALLOW_COPY_AND_ASSIGN(RenderViewDevToolsAgentHost);
138 }; 137 };
139 138
140 } // namespace content 139 } // namespace content
141 140
142 #endif // CONTENT_BROWSER_DEVTOOLS_RENDER_VIEW_DEVTOOLS_AGENT_HOST_H_ 141 #endif // CONTENT_BROWSER_DEVTOOLS_RENDER_VIEW_DEVTOOLS_AGENT_HOST_H_
OLDNEW
« no previous file with comments | « content/browser/devtools/devtools_frontend_host_impl.cc ('k') | content/browser/devtools/render_view_devtools_agent_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698