Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Unified Diff: content/shell/renderer/test_runner/web_ax_object_proxy.cc

Issue 744623002: Exposing ARIA state/property aria-orientation on Windows correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updating aria-list on mac Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/test_runner/web_ax_object_proxy.cc
diff --git a/content/shell/renderer/test_runner/web_ax_object_proxy.cc b/content/shell/renderer/test_runner/web_ax_object_proxy.cc
index 3d7f17d0377718b3efa33930d509f055d30fe8b0..ad413e346658eea8007ddcc81f2e89aee3ed21aa 100644
--- a/content/shell/renderer/test_runner/web_ax_object_proxy.cc
+++ b/content/shell/renderer/test_runner/web_ax_object_proxy.cc
@@ -297,13 +297,6 @@ std::string GetTitle(const blink::WebAXObject& object) {
return title.insert(0, "AXTitle: ");
}
-std::string GetOrientation(const blink::WebAXObject& object) {
- if (object.isVertical())
- return "AXOrientation: AXVerticalOrientation";
-
- return "AXOrientation: AXHorizontalOrientation";
-}
-
std::string GetValueDescription(const blink::WebAXObject& object) {
std::string value_description = object.valueDescription().utf8();
return value_description.insert(0, "AXValueDescription: ");
@@ -776,7 +769,12 @@ bool WebAXObjectProxy::IsReadOnly() {
std::string WebAXObjectProxy::Orientation() {
accessibility_object_.updateLayoutAndCheckValidity();
- return GetOrientation(accessibility_object_);
+ if (accessibility_object_.orientation() == blink::WebAXOrientationVertical)
+ return "AXOrientation: AXVerticalOrientation";
+ else if (accessibility_object_.orientation() == blink::WebAXOrientationHorizontal)
+ return "AXOrientation: AXHorizontalOrientation";
+
+ return std::string();
}
int WebAXObjectProxy::ClickPointX() {

Powered by Google App Engine
This is Rietveld 408576698