Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 744533004: Fix pylint warnings (Closed)

Created:
6 years, 1 month ago by Yufeng Shen (Slow to review)
Modified:
6 years, 1 month ago
Reviewers:
nednguyen, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix pylint warnings ** Presubmit Warnings ** Pylint (435 files) (35.97s) failed ************* Module telemetry.page.page_test_unittest W: 17, 0: Unused import scalar (unused-import) ************* Module telemetry.unittest_util.run_tests_unittest C: 44, 0: Exactly one space required before assignment host = runner.host ^ (bad-whitespace) BUG= Committed: https://crrev.com/198f170a152a2755a238ac6e97ecf2a6d0cbec52 Cr-Commit-Position: refs/heads/master@{#305070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tools/telemetry/telemetry/page/page_test_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/unittest_util/run_tests_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Yufeng Shen (Slow to review)
6 years, 1 month ago (2014-11-20 19:06:33 UTC) #2
tonyg
lgtm
6 years, 1 month ago (2014-11-20 19:10:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744533004/1
6 years, 1 month ago (2014-11-20 19:11:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 20:15:48 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 20:16:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/198f170a152a2755a238ac6e97ecf2a6d0cbec52
Cr-Commit-Position: refs/heads/master@{#305070}

Powered by Google App Engine
This is Rietveld 408576698