Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Unified Diff: Source/core/rendering/RenderTableRow.cpp

Issue 744493002: Let RenderTable reach table cells needing overflow recalc (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: RenderTableRow::recomputeOverflow Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderTableRow.cpp
diff --git a/Source/core/rendering/RenderTableRow.cpp b/Source/core/rendering/RenderTableRow.cpp
index 6e051cd04d25468538bfdf3c98a6904efddc502a..2a1f9de5c92849ed7387dc221265ff4ee921a21b 100644
--- a/Source/core/rendering/RenderTableRow.cpp
+++ b/Source/core/rendering/RenderTableRow.cpp
@@ -245,9 +245,18 @@ RenderTableRow* RenderTableRow::createAnonymousWithParentRenderer(const RenderOb
return newRow;
}
+void RenderTableRow::recomputeOverflow()
+{
+ clearAllOverflows();
+ addVisualEffectOverflow();
+ for (RenderTableCell* cell = firstCell(); cell; cell = cell->nextCell())
+ addOverflowFromCell(cell);
+}
+
void RenderTableRow::addOverflowFromCell(const RenderTableCell* cell)
{
// Non-row-spanning-cells don't create overflow (they are fully contained within this row).
+ // FIXME: This seems incorrect because cell may have visual effect overflow that should be included in this row.
if (cell->rowSpan() == 1)
return;

Powered by Google App Engine
This is Rietveld 408576698