LayoutTests/fast/table/outline-change-in-table-cell-expected.txt - Issue 744493002: Let RenderTable reach table cells needing overflow recalc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/table/outline-change-in-table-cell-expected.txt

Issue 744493002: Let RenderTable reach table cells needing overflow recalc (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix layout test crash Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 {

	2 "bounds": [800, 600],

	3 "children": [

	4 {

	5 "bounds": [800, 600],

	6 "contentsOpaque": true,

	7 "drawsContent": true,

	8 "repaintRects": [

	9 [40, 148, 102, 102],

	10 [40, 148, 102, 102],

	11 [38, 146, 106, 106],

	12 [38, 146, 106, 106],

	13 [21, 129, 140, 140],

	14 [21, 129, 140, 140],

	15 [21, 129, 140, 140],

	16 [21, 129, 140, 140],
	Julien - ping for review 2014/11/22 02:35:04 That's a lot of invalidations when you know that That's a lot of invalidations when you know that only a single cell has changed. Xianzhu 2014/11/24 17:23:00 These are expected based on current table layout c Show quoted text On 2014/11/22 02:35:04, Julien Chaffraix - PST wrote: > That's a lot of invalidations when you know that only a single cell has > changed. These are expected based on current table layout code because cell's overflow also contributes to overflow of its containing row, section, and table.
	17 [8, 252, 784, 17]
	Julien - ping for review 2014/11/22 02:35:04 That's a lot of invalidations when we know that That's a lot of invalidations when we know that a single cell has changed in the test case. Xianzhu 2014/11/24 17:23:00 This is the overflow change of <BODY>. I can make Show quoted text On 2014/11/22 02:35:04, Julien Chaffraix - PST wrote: > That's a lot of invalidations when we know that a single cell has changed in > the test case. This is the overflow change of <BODY>. I can make the table position:absolute to avoid this. Xianzhu 2014/11/24 17:23:00 The overflow change also propagates to <BODY>. Show quoted text On 2014/11/22 02:35:04, Julien Chaffraix - PST wrote: > That's a lot of invalidations when we know that a single cell has changed in > the test case. The overflow change also propagates to <BODY>.
	18 ]

	19 }

	20 ]

	21 }

	22

OLD	NEW