Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 744483002: Setting --enable-gpu-benchmarking should force all Finch trials to default (Closed)

Created:
6 years, 1 month ago by oystein (OOO til 10th of July)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, erikwright+watch_chromium.org, Ilya Sherman, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Setting --enable-gpu-benchmarking should force all Finch trials to default R=thestig@chromium.org,asvitkine@chromium.org,cpu@chromium.org BUG=434756 Committed: https://crrev.com/991568bbf333913fe20b760b49ea02d53b806354 Cr-Commit-Position: refs/heads/master@{#305129}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Nit fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/chrome_browser_main.cc View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
oystein (OOO til 10th of July)
6 years, 1 month ago (2014-11-20 00:37:59 UTC) #1
Lei Zhang
lgtm with Alexei's approval.
6 years, 1 month ago (2014-11-20 00:42:09 UTC) #3
Alexei Svitkine (slow)
lgtm with a nit https://codereview.chromium.org/744483002/diff/20001/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/744483002/diff/20001/chrome/browser/chrome_browser_main.cc#newcode606 chrome/browser/chrome_browser_main.cc:606: command_line->HasSwitch(cc::switches::kEnableGpuBenchmarking)) Nit: {}'s
6 years, 1 month ago (2014-11-20 18:21:56 UTC) #4
cpu_(ooo_6.6-7.5)
lgtm
6 years, 1 month ago (2014-11-20 22:26:23 UTC) #5
oystein (OOO til 10th of July)
Thanks! https://codereview.chromium.org/744483002/diff/20001/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/744483002/diff/20001/chrome/browser/chrome_browser_main.cc#newcode606 chrome/browser/chrome_browser_main.cc:606: command_line->HasSwitch(cc::switches::kEnableGpuBenchmarking)) On 2014/11/20 18:21:56, Alexei Svitkine wrote: > ...
6 years, 1 month ago (2014-11-20 22:55:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744483002/40001
6 years, 1 month ago (2014-11-20 22:56:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 1 month ago (2014-11-21 00:57:30 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 00:58:07 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/991568bbf333913fe20b760b49ea02d53b806354
Cr-Commit-Position: refs/heads/master@{#305129}

Powered by Google App Engine
This is Rietveld 408576698