Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 744363002: Remove NodeIterator.expandEntityReferences / TreeWalker.expandEntityReferences (Closed)

Created:
6 years, 1 month ago by philipj_slow
Modified:
6 years, 1 month ago
Reviewers:
tkent
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Project:
blink
Visibility:
Public.

Description

Remove NodeIterator.expandEntityReferences / TreeWalker.expandEntityReferences Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/-ZO3eja4maA/86T13XJwQpUJ BUG=367866 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -44 lines) Patch
M LayoutTests/fast/dom/NodeIterator/NodeIterator-basic.html View 1 chunk +0 lines, -13 lines 0 comments Download
M LayoutTests/fast/dom/NodeIterator/NodeIterator-basic-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/TreeWalker/TreeWalker-basic.html View 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/fast/dom/TreeWalker/TreeWalker-basic-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/dom/NodeIterator.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/NodeIteratorBase.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/dom/TreeWalker.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
6 years, 1 month ago (2014-11-21 06:35:06 UTC) #2
tkent
lgtm
6 years, 1 month ago (2014-11-21 06:40:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744363002/1
6 years, 1 month ago (2014-11-21 06:41:21 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 07:40:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185771

Powered by Google App Engine
This is Rietveld 408576698