runtime/vm/regexp.cc - Issue 744323005: Don't check against __BYTE_ORDER__ when not defined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/regexp.cc

Issue 744323005: Don't check against __BYTE_ORDER__ when not defined. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/regexp.cc

diff --git a/runtime/vm/regexp.cc b/runtime/vm/regexp.cc

index edb9d26e3a3b9b67eb114f5f770ad51a34de2145..a996a114f43d5bd4823ecc80853a4137893d3cf5 100644

--- a/runtime/vm/regexp.cc

+++ b/runtime/vm/regexp.cc

@@ -1807,7 +1807,7 @@ void TextNode::GetQuickCheckDetails(QuickCheckDetails* details,

RegExpCompiler* compiler,

intptr_t characters_filled_in,

bool not_at_start) {

-#if defined(__GNUC__)

+#if defined(__GNUC__) && defined(__BYTE_ORDER__)

// TODO(zerny): Make the combination code byte-order independent.

ASSERT(details->characters() == 1 ||

(__BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__));

« no previous file with comments | « no previous file | no next file » | no next file with comments »