Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 744283002: Revert of Disable telemetry tests for Mac 10.9. (Closed)

Created:
6 years, 1 month ago by dtu
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable telemetry tests for Mac 10.9. (patchset #2 id:20001 of https://codereview.chromium.org/706703003/) Reason for revert: Second attempt to re-enable tests. I think there may still be one test failure, but we can disable that one test. If there's more than one, revert this. Original issue's description: > Disable telemetry tests for Mac 10.9. > > The telemetry tests are failing consistently on OSX 10.9. > > BUG=420615 > R=tonyg@chromium.org > > Committed: https://crrev.com/5503de1eeae0437c1f8160d69b04d6241bc5e974 > Cr-Commit-Position: refs/heads/master@{#303114} TBR=phajdan.jr@chromium.org,tonyg@chromium.org,garykac@chromium.org NOTREECHECKS=true NOTRY=true BUG=420615 Committed: https://crrev.com/10e58e6dfbe4d9dae5841ceb9eb0180cce1aac14 Cr-Commit-Position: refs/heads/master@{#305096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M testing/buildbot/chromium.mac.json View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dtu
Created Revert of Disable telemetry tests for Mac 10.9.
6 years, 1 month ago (2014-11-20 22:48:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744283002/1
6 years, 1 month ago (2014-11-20 22:50:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 22:52:47 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/10e58e6dfbe4d9dae5841ceb9eb0180cce1aac14 Cr-Commit-Position: refs/heads/master@{#305096}
6 years, 1 month ago (2014-11-20 22:53:27 UTC) #4
Finnur
6 years, 1 month ago (2014-11-21 11:26:46 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/751533002/ by finnur@chromium.org.

The reason for reverting is: This re-enabling of tests has left a trail of
redness on Mac 10.9 (more than one failure). If you expect tests to fail as a
result of re-enabling again, then please watch the tree and disable the ones
failing (assuming that is the appropriate course of action in the first place,
which I'm not sure of)..

Powered by Google App Engine
This is Rietveld 408576698