Add optimized String.fromCharCodes path for Uint8List and Int8List.

runtime/lib/string_patch.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 patch class String {
   /* patch */ factory String.fromCharCodes(Iterable<int> charCodes) {
     return _StringBase.createFromCharCodes(charCodes);
   }
 
   /* patch */ const factory String.fromEnvironment(String name,
@@ skipping 16 matching lines @@
   Type get runtimeType => String;
 
   int get hashCode native "String_getHashCode";
 
   /**
    *  Create the most efficient string representation for specified
    *  [codePoints].
    */
   static String createFromCharCodes(Iterable<int> charCodes) {
     if (charCodes != null) {
-      // TODO(srdjan): Also skip copying of typed arrays.
+      // TODO(srdjan): Also skip copying of wide typed arrays.
       final ccid = charCodes._cid;
+      bool isOneByteString = false;
       if ((ccid != _List._classId) &&
           (ccid != _GrowableList._classId) &&
           (ccid != _ImmutableList._classId)) {
-        charCodes = new List<int>.from(charCodes, growable: false);
+        if (charCodes is Uint8List || charCodes is Int8List) {

[srdjan, 2013/11/20 16:06:57]

Add parentheses around is tests.

[Anders Johnsen, 2013/11/21 06:06:27]

Done.

+          isOneByteString = true;
+        } else {
+          charCodes = new List<int>.from(charCodes, growable: false);
+        }
       }
 
-      bool isOneByteString = true;
-      for (int i = 0; i < charCodes.length; i++) {
-        int e = charCodes[i];
-        if (e is! _Smi) throw new ArgumentError(e);
-        // Is e Latin1?
-        if ((e < 0) || (e > 0xFF)) {
-          isOneByteString = false;
-          break;
+      if (!isOneByteString) {
+        for (int i = 0; i < charCodes.length; i++) {

[srdjan, 2013/11/20 16:06:57]

You may want to prefetch chatCodes.length and keep it in a final variable. It
may not help, but it would not hurt.

[Anders Johnsen, 2013/11/21 06:06:27]

Done.

+          int e = charCodes[i];
+          if (e is! _Smi) throw new ArgumentError(e);
+          // Is e Latin1?
+          if ((e < 0) || (e > 0xFF)) {
+            return _createFromCodePoints(charCodes);
+          }
         }
       }
-      if (isOneByteString) {
-        var s = _OneByteString._allocate(charCodes.length);
-        for (int i = 0; i < charCodes.length; i++) {
-          s._setAt(i, charCodes[i]);
-        }
-        return s;
+
+      // Allocate a one byte string.

[srdjan, 2013/11/20 16:06:57]

Add a comment that above the threshold, the native code is faster. Is 128 the
proper threshold?

[Anders Johnsen, 2013/11/21 06:06:27]

Just did a test with normal lists. 128 is indeed the magic number.

+      if (charCodes.length >= 128) {
+        return _OneByteString._allocateFromOneByteList(charCodes);
       }
+
+      var s = _OneByteString._allocate(charCodes.length);
+      for (int i = 0; i < charCodes.length; i++) {
+        s._setAt(i, charCodes[i]);
+      }
+      return s;
     }
     return _createFromCodePoints(charCodes);
   }
 
   static String _createFromCodePoints(List<int> codePoints)
       native "StringBase_createFromCodePoints";
 
   String operator [](int index) native "String_charAt";
 
   int codeUnitAt(int index) native "String_codeUnitAt";
@@ skipping 549 matching lines @@
         return false;
       }
     }
     return super.contains(pattern, start);
   }
 
   // Allocates a string of given length, expecting its content to be
   // set using _setAt.
   static _OneByteString _allocate(int length) native "OneByteString_allocate";
 
+
+  static _OneByteString _allocateFromOneByteList(List<int> list)
+      native "OneByteString_allocateFromOneByteList";
+
   // This is internal helper method. Code point value must be a valid
   // Latin1 value (0..0xFF), index must be valid.
   void _setAt(int index, int codePoint) native "OneByteString_setAt";
 }
 
 
 class _TwoByteString extends _StringBase implements String {
   static final int _classId = "\u{FFFF}"._cid;
 
   factory _TwoByteString._uninstantiable() {
@@ skipping 82 matching lines @@
 class _CodeUnits extends Object with ListMixin<int>,
                                      UnmodifiableListMixin<int> {
   /** The string that this is the code units of. */
   String _string;
 
   _CodeUnits(this._string);
 
   int get length => _string.length;
   int operator[](int i) => _string.codeUnitAt(i);
 }