Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 744223002: Fix mac sizes The mac build updated to build 64 bit binaries, so the sizes (Closed)

Created:
6 years, 1 month ago by Pete Williamson
Modified:
6 years, 1 month ago
Reviewers:
dtu
CC:
chromium-reviews, Robert Sesek
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix mac sizes The mac build updated to build 64 bit binaries, so the sizes changed about 5-15% for some binaries. BUG=435304 R=dtu@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/4c66f8158e51c04596c34d53637279a9f16ce019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/perf_expectations/perf_expectations.json View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Pete Williamson
DTu@ - Please revivew carefully, I'm a regular sheriff, not a perf sheriff, so this ...
6 years, 1 month ago (2014-11-20 21:56:53 UTC) #2
dtu
Heh, I've only done it once before as well. But the improve/regress ranges look good ...
6 years, 1 month ago (2014-11-20 22:08:50 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4c66f8158e51c04596c34d53637279a9f16ce019 Cr-Commit-Position: refs/heads/master@{#305088}
6 years, 1 month ago (2014-11-20 22:25:05 UTC) #4
Pete Williamson
6 years, 1 month ago (2014-11-20 22:25:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4c66f8158e51c04596c34d53637279a9f16ce019 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698