Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 744193002: Android video capture: Set camera parameters continuous focus mode on, where supported (Closed)

Created:
6 years, 1 month ago by mcasas
Modified:
6 years, 1 month ago
Reviewers:
qinmin
CC:
chromium-reviews, posciak+watch_chromium.org, wjia+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Android video capture: Set camera parameters continuous focus mode on, where supported This is, apparently, needed for macro modes, although autofocus seems to work ok in general. A similar CL was landed and reverted (http://crrev.com/737003003). This CL is an alternative where the supported focus modes are tested before being set in the Camera.Parameters. BUG=343894 TEST=Please refer to the bug, basically a gUM() + close text or QR codes focus test. Committed: https://crrev.com/0910435eba14f433438ed2e448a67e799e851bdd Cr-Commit-Position: refs/heads/master@{#305117}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M media/base/android/java/src/org/chromium/media/VideoCaptureCamera.java View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mcasas
qinmin@: RS/FYI/...
6 years, 1 month ago (2014-11-20 21:24:02 UTC) #3
qinmin
lgtm
6 years, 1 month ago (2014-11-20 21:49:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744193002/20001
6 years, 1 month ago (2014-11-20 23:04:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years, 1 month ago (2014-11-21 00:11:09 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 00:12:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0910435eba14f433438ed2e448a67e799e851bdd
Cr-Commit-Position: refs/heads/master@{#305117}

Powered by Google App Engine
This is Rietveld 408576698