chrome/browser/safe_browsing/safe_browsing_store_file.h - Issue 744183002: More explicit thread checking in SafeBrowsingDatabase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_store_file.h

Issue 744183002: More explicit thread checking in SafeBrowsingDatabase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a3_deadcode

Patch Set: crbug.com/338486 forces thread-checks to be disabled in ~SafeBrowsingStoreFile() Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/safe_browsing_database.cc ('K') | « chrome/browser/safe_browsing/safe_browsing_database_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_store_file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_store_file.h

diff --git a/chrome/browser/safe_browsing/safe_browsing_store_file.h b/chrome/browser/safe_browsing/safe_browsing_store_file.h

index 7497c9bfcb4795c64afc19703d0e4deb6b05e2b6..2c2e04cef76f3194d64a166e2bd53d2fbaa1960f 100644

--- a/chrome/browser/safe_browsing/safe_browsing_store_file.h

+++ b/chrome/browser/safe_browsing/safe_browsing_store_file.h

@@ -13,6 +13,7 @@

#include "base/callback.h"

#include "base/files/file_path.h"

#include "base/files/scoped_file.h"

+#include "base/threading/non_thread_safe.h"

// Implement SafeBrowsingStore in terms of a flat file. The file

// format is pretty literal:

@@ -122,7 +123,8 @@

// - Delete original file.

// - Rename temp file to original filename.

-class SafeBrowsingStoreFile : public SafeBrowsingStore {

+class SafeBrowsingStoreFile : public SafeBrowsingStore,

+ public base::NonThreadSafe {

public:

SafeBrowsingStoreFile();

~SafeBrowsingStoreFile() override;