Issue 744143002: Add a new v8_inspector target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 744143002: Add a new v8_inspector target (Closed)

Created:
6 years, 1 month ago by eseidel

Modified:
6 years, 1 month ago

Reviewers:
yurys, abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add a new v8_inspector target v8_inspector is a peer to web for now. Eventually it should be its own separate target and not depend on core or platform at all, but we can't yet. This creates a place for us to move the debugger-inspector code to so it can be refactored to not depend on core. I also moved the public target for sky out of public/ and renamed it "engine" instead of blink. R=abarth@chromium.org, yurys@chromium.org BUG=435243 Committed: https://chromium.googlesource.com/external/mojo/+/8aa80d38de3558957b9dc210ed24d865a7e7b9d6

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -11 lines)			Patch
M	sky/engine/BUILD.gn	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	sky/engine/public/BUILD.gn	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	sky/engine/testing/platform/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
A	sky/engine/v8_inspector/BUILD.gn	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	sky/viewer/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/viewer/cc/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

6 years, 1 month ago (2014-11-20 19:00:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8aa80d38de3558957b9dc210ed24d865a7e7b9d6 (presubmit successful).

Expand Messages | Collapse Messages