Remove unnecessary overrides and test

Remove unnecessary overrides and test

SuggestionsServiceFactory::GetForProfile() returns nullptr if
Profile::IsOffTheRecord() is true. So when another factory or
client code use the helper method to get the service, it gets
a nullptr.

The SuggestionsServiceFactory::GetBrowserContextToUse() test
happens only in the GetServiceForBrowserContext() call, and
thus does not happens when client code use this helper method.

The only situation where GetBrowserContextToUse() could be
called is if code directly call GetServiceForBrowserContext
or if ServiceIsCreatedWithBrowserContext() were overridden
to returns true.

Since none of those two conditions are true, then the method
is never called with an off-the-record Profile and the default
implementation inherited from BrowserContextKeyedServiceFactory
does the right thing (i.e. returns nullptr, which in turn cause
GetServiceForBrowserContext to return nullptr).

BUG=None

Committed: https://crrev.com/512e25f331e03b33c60d9e9ec6fcb9f42761985e
Cr-Commit-Position: refs/heads/master@{#305059}

[sdefresne, 2014-11-20 14:19:58]

sdefresne@chromium.org changed reviewers:
+ mathp@chromium.org

[sdefresne, 2014-11-20 14:19:59]

This CL does not change functionality as
BrowserContextKeyedServiceFactory::GetBrowserContextToUse returns nullptr by
default when Profile::IsOffTheRecord is true (and thus
GetServiceForBrowserContext returns nullptr).

[Mathieu, 2014-11-20 17:19:12]

Makes sense, lgtm

[sdefresne, 2014-11-20 17:23:06]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-11-20 17:23:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/744033002/1

[commit-bot: I haz the power, 2014-11-20 19:18:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-20 19:19:13]

Patchset 1 (id:??) landed as
https://crrev.com/512e25f331e03b33c60d9e9ec6fcb9f42761985e
Cr-Commit-Position: refs/heads/master@{#305059}