Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 7439009: Added code to change the folder permissions of /etc/opt/chrome (Closed)

Created:
9 years, 5 months ago by aocampo
Modified:
9 years, 5 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews
Visibility:
Public.

Description

Added code to change the directory permissions for /etc/opt/chrome that contains the chrome.json file BUG=89675 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93130

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M enterprise_helper_linux.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
aocampo
9 years, 5 months ago (2011-07-19 19:20:47 UTC) #1
Nirnimesh
http://codereview.chromium.org/7439009/diff/1/enterprise_helper_linux.py File enterprise_helper_linux.py (right): http://codereview.chromium.org/7439009/diff/1/enterprise_helper_linux.py#newcode17 enterprise_helper_linux.py:17: filename = sys.argv[3] + '/chrome.json' use os.path.join() http://codereview.chromium.org/7439009/diff/1/enterprise_helper_linux.py#newcode18 enterprise_helper_linux.py:18: ...
9 years, 5 months ago (2011-07-19 19:27:41 UTC) #2
aocampo
http://codereview.chromium.org/7439009/diff/1/enterprise_helper_linux.py File enterprise_helper_linux.py (right): http://codereview.chromium.org/7439009/diff/1/enterprise_helper_linux.py#newcode17 enterprise_helper_linux.py:17: filename = sys.argv[3] + '/chrome.json' On 2011/07/19 19:27:41, Nirnimesh ...
9 years, 5 months ago (2011-07-19 20:20:58 UTC) #3
Nirnimesh
Enable this test in PYAUTO_TESTS
9 years, 5 months ago (2011-07-19 21:03:06 UTC) #4
aocampo
On 2011/07/19 21:03:06, Nirnimesh wrote: > Enable this test in PYAUTO_TESTS Done.
9 years, 5 months ago (2011-07-19 21:26:04 UTC) #5
Nirnimesh
LGTM. Watch out on the bots.
9 years, 5 months ago (2011-07-19 21:32:09 UTC) #6
commit-bot: I haz the power
Change committed as 93130
9 years, 5 months ago (2011-07-19 23:54:43 UTC) #7
aocampo
9 years, 5 months ago (2011-07-20 17:42:48 UTC) #8
Nirnimesh
9 years, 5 months ago (2011-07-20 21:15:45 UTC) #9
No. Create a new CL.

On Wed, Jul 20, 2011 at 10:42 AM, <aocampo@chromium.org> wrote:

>
http://codereview.chromium.**org/7439009/<http://codereview.chromium.org/7439...
>



-- 
../NiR

Powered by Google App Engine
This is Rietveld 408576698