Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 743843003: Slightly improve tests that rely on lazy compilation. (Closed)

Created:
6 years, 1 month ago by Yang
Modified:
6 years, 1 month ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Slightly improve tests that rely on lazy compilation. R=rossberg@chromium.org BUG=v8:3712 LOG=N Committed: https://chromium.googlesource.com/v8/v8/+/ff266b3ab928eb727d9f949cc0b36ddca059fc63

Patch Set 1 #

Patch Set 2 : strict mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/mjsunit/function-length-accessor.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-2506.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Yang
6 years, 1 month ago (2014-11-20 15:28:43 UTC) #1
rossberg
lgtm
6 years, 1 month ago (2014-11-20 15:35:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/743843003/1
6 years, 1 month ago (2014-11-20 15:37:09 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/1413)
6 years, 1 month ago (2014-11-20 15:52:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/743843003/20001
6 years, 1 month ago (2014-11-21 12:13:08 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-21 12:41:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698