content/browser/frame_host/render_frame_host_impl.cc - Issue 743803002: Avoid stale navigation requests without excessive page id knowledge in the renderer process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 743803002: Avoid stale navigation requests without excessive page id knowledge in the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_controller_impl_unittest.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index 13bb3160d551efa1c33bffcfa522c75108cc4ada..8807340a3ba21f27905707c46ef4fbd788ad706c 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -1257,7 +1257,7 @@ void RenderFrameHostImpl::Navigate(const FrameMsg_Navigate_Params& params) {

// loading" message will be received asynchronously from the UI of the

// browser. But we want to keep the throbber in sync with what's happening

// in the UI. For example, we want to start throbbing immediately when the

- // user naivgates even if the renderer is delayed. There is also an issue

+ // user navigates even if the renderer is delayed. There is also an issue

// with the throbber starting because the WebUI (which controls whether the

// favicon is displayed) happens synchronously. If the start loading

// messages was asynchronous, then the default favicon would flash in.