content/browser/web_contents/web_contents_impl_unittest.cc - Issue 743803002: Avoid stale navigation requests without excessive page id knowledge in the renderer process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 743803002: Avoid stale navigation requests without excessive page id knowledge in the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixes, test Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_controller_impl_browsertest.cc ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | content/common/frame_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl_unittest.cc

diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc

index a361553dd25adfef25da829d420bb45370cc4b23..ba1a8f00734c0f34eb5ead8f5146a8ae860aa2e3 100644

--- a/content/browser/web_contents/web_contents_impl_unittest.cc

+++ b/content/browser/web_contents/web_contents_impl_unittest.cc

@@ -2282,10 +2282,7 @@ TEST_F(WebContentsImplTest, CopyStateFromAndPruneSourceInterstitial) {

static_cast<TestWebContents*>(CreateTestWebContents()));

NavigationControllerImpl& other_controller = other_contents->GetController();

other_contents->NavigateAndCommit(url3);

- other_contents->ExpectSetHistoryLengthAndPrune(

- NavigationEntryImpl::FromNavigationEntry(

- other_controller.GetEntryAtIndex(0))->site_instance(), 1,

- other_controller.GetEntryAtIndex(0)->GetPageID());

+ other_contents->ExpectSetHistoryOffsetAndLength(1, 2);

other_controller.CopyStateFromAndPrune(&controller(), false);

// The merged controller should only have two entries: url1 and url2.