Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: content/public/test/render_view_test.cc

Issue 743803002: Avoid stale navigation requests without excessive page id knowledge in the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more saving Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/render_view_test.cc
diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc
index 0b43c358105a4e2ee0dca721b4ff37e010fff73f..7bbe0c096b174e8fc07e293b3f5c8c8ae274ce22 100644
--- a/content/public/test/render_view_test.cc
+++ b/content/public/test/render_view_test.cc
@@ -336,14 +336,6 @@ void RenderViewTest::SetFocused(const blink::WebNode& node) {
impl->focusedNodeChanged(node);
}
-void RenderViewTest::ClearHistory() {
- RenderViewImpl* impl = static_cast<RenderViewImpl*>(view_);
- impl->page_id_ = -1;
- impl->history_list_offset_ = -1;
- impl->history_list_length_ = 0;
- impl->history_page_ids_.clear();
-}
-
void RenderViewTest::Reload(const GURL& url) {
FrameMsg_Navigate_Params params;
params.common_params.url = url;
@@ -420,14 +412,14 @@ void RenderViewTest::GoToOffset(int offset, const PageState& state) {
int history_list_length = impl->historyBackListCount() +
impl->historyForwardListCount() + 1;
- int pending_offset = offset + impl->history_list_offset();
+ int pending_offset = offset + impl->history_list_offset_;
FrameMsg_Navigate_Params navigate_params;
navigate_params.common_params.navigation_type =
FrameMsg_Navigate_Type::NORMAL;
navigate_params.common_params.transition = ui::PAGE_TRANSITION_FORWARD_BACK;
navigate_params.current_history_list_length = history_list_length;
- navigate_params.current_history_list_offset = impl->history_list_offset();
+ navigate_params.current_history_list_offset = impl->history_list_offset_;
navigate_params.pending_history_list_offset = pending_offset;
navigate_params.page_id = impl->page_id_ + offset;
navigate_params.commit_params.page_state = state;

Powered by Google App Engine
This is Rietveld 408576698