Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 743803002: Avoid stale navigation requests without excessive page id knowledge in the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: more saving Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 8e1c65719186c10b67c940f7db1b2df4e72556b3..9f0da6bc14d20015592ec9ad8862285625ba687a 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -610,13 +610,10 @@ class CONTENT_EXPORT WebContentsImpl
bool NavigateToPendingEntry(
NavigationController::ReloadType reload_type) override;
- // Sets the history for this WebContentsImpl to |history_length| entries, and
- // moves the current page_id to the last entry in the list if it's valid.
- // This is mainly used when a prerendered page is swapped into the current
- // tab. The method is virtual for testing.
- void SetHistoryLengthAndPrune(const SiteInstance* site_instance,
- int merge_history_length,
- int32 minimum_page_id) override;
+ // Sets the history for this WebContentsImpl to |history_length| entries, with
+ // an offset of |history_offset|.
+ void SetHistoryOffsetAndLength(int history_offset,
+ int history_length) override;
// Called by InterstitialPageImpl when it creates a RenderFrameHost.
void RenderFrameForInterstitialPageCreated(
@@ -888,6 +885,12 @@ class CONTENT_EXPORT WebContentsImpl
// Misc non-view stuff -------------------------------------------------------
+ // Sets the history for a specified RenderViewHost to |history_length|
+ // entries, with an offset of |history_offset|.
+ void SetHistoryOffsetAndLengthForView(RenderViewHost* render_view_host,
+ int history_offset,
+ int history_length);
+
// Helper functions for sending notifications.
void NotifyViewSwapped(RenderViewHost* old_host, RenderViewHost* new_host);
void NotifyFrameSwapped(RenderFrameHost* old_host, RenderFrameHost* new_host);

Powered by Google App Engine
This is Rietveld 408576698