content/browser/frame_host/render_frame_host_impl.h - Issue 743773003: OOPIF: Data URLs are now rendered in the renderer that initiated the navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 743773003: OOPIF: Data URLs are now rendered in the renderer that initiated the navigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_entry_impl.h ('K') | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.h

diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h

index 052da3b4366107390320f166275346c975e2fb4d..fc923347275e6e193ca267344225d1ef826d427d 100644

--- a/content/browser/frame_host/render_frame_host_impl.h

+++ b/content/browser/frame_host/render_frame_host_impl.h

@@ -272,8 +272,11 @@ class CONTENT_EXPORT RenderFrameHostImpl

// Treat this prospective navigation as thought it originated from the

// frame. Used, e.g., for a navigation request that originated from

- // a RemoteFrame.

- void OpenURL(const FrameHostMsg_OpenURL_Params& params);

+ // a RemoteFrame. |site_instance| is the site instance that initiated the

+ // navigation request, and should only be used when a cross-site navigation is

+ // initiated by a remote frame.

Charlie Reis 2014/12/06 00:18:50 Let's call it source_site_instance and update the

lfg 2014/12/08 20:45:33 Done.

+ void OpenURL(const FrameHostMsg_OpenURL_Params& params,

+ SiteInstance* site_instance);

// Stop the load in progress.

void Stop();