content/browser/security_exploit_browsertest.cc - Issue 743773003: OOPIF: Data URLs are now rendered in the renderer that initiated the navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/security_exploit_browsertest.cc

Issue 743773003: OOPIF: Data URLs are now rendered in the renderer that initiated the navigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixing android compile Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/security_exploit_browsertest.cc

diff --git a/content/browser/security_exploit_browsertest.cc b/content/browser/security_exploit_browsertest.cc

index be65a56546ac5e9274b79ce6ad3bfc3e12e99a3f..610078fd42e6fa6b9cc7559041b2a4735dc88546 100644

--- a/content/browser/security_exploit_browsertest.cc

+++ b/content/browser/security_exploit_browsertest.cc

@@ -68,9 +68,8 @@ RenderViewHostImpl* PrepareToDuplicateHosts(Shell* shell,

GURL extension_url("https://bar.com/simple_page.html");

WebContentsImpl* wc = static_cast<WebContentsImpl*>(shell->web_contents());

wc->GetFrameTree()->root()->navigator()->RequestOpenURL(

- wc->GetFrameTree()->root()->current_frame_host(), extension_url,

- Referrer(), CURRENT_TAB,

- false, true);

+ wc->GetFrameTree()->root()->current_frame_host(), extension_url, nullptr,

+ Referrer(), CURRENT_TAB, false, true);

// Since the navigation above requires a cross-process swap, there will be a

// pending RenderViewHost. Ensure it exists and is in a different process

« no previous file with comments | « content/browser/frame_host/render_frame_proxy_host.cc ('k') | content/browser/site_per_process_browsertest.cc » ('j') | no next file with comments »