content/browser/frame_host/render_frame_host_manager.cc - Issue 743773003: OOPIF: Data URLs are now rendered in the renderer that initiated the navigation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 743773003: OOPIF: Data URLs are now rendered in the renderer that initiated the navigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigator_impl.cc ('K') | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/frame_host/render_frame_proxy_host.cc » ('j') | content/public/browser/navigation_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager.cc

diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc

index 7780cc05e2c90df1464137488038106a0f2316f6..86378d3906156fca28eed87d822ab634ce4c2e54 100644

--- a/content/browser/frame_host/render_frame_host_manager.cc

+++ b/content/browser/frame_host/render_frame_host_manager.cc

@@ -376,15 +376,9 @@ void RenderFrameHostManager::OnCrossSiteResponse(

// However, since we force the navigation to be in the current tab, it

// doesn't matter.

pending_render_frame_host->frame_tree_node()->navigator()->RequestTransferURL(

- pending_render_frame_host,

- transfer_url,

- rest_of_chain,

- referrer,

- page_transition,

- CURRENT_TAB,

- global_request_id,

- should_replace_current_entry,

- true);

+ pending_render_frame_host, transfer_url, nullptr, rest_of_chain, referrer,

+ page_transition, CURRENT_TAB, global_request_id,

+ should_replace_current_entry, true);

// The transferring request was only needed during the RequestTransferURL

// call, so it is safe to clear at this point.