Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 743773003: OOPIF: Data URLs are now rendered in the renderer that initiated the navigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_controller_impl.cc
diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc
index 4be5a3ce4a009f07a74d87de92730bec3740c2b7..3ca4525f1e74e296181acc3ab3a727a037021b12 100644
--- a/content/browser/frame_host/navigation_controller_impl.cc
+++ b/content/browser/frame_host/navigation_controller_impl.cc
@@ -721,6 +721,10 @@ void NavigationControllerImpl::LoadURLWithParams(const LoadURLParams& params) {
browser_context_));
if (params.frame_tree_node_id != -1)
entry->set_frame_tree_node_id(params.frame_tree_node_id);
+ if (params.url.scheme() == url::kDataScheme && params.site_instance.get()) {
Charlie Reis 2014/11/20 19:58:43 Hmm, this doesn't feel right to me. Process model
lfg 2014/12/05 21:55:42 Done that, though there's a scary comment about th
+ entry->set_site_instance(
+ static_cast<SiteInstanceImpl*>(params.site_instance.get()));
+ }
if (params.redirect_chain.size() > 0)
entry->SetRedirectChain(params.redirect_chain);
if (params.should_replace_current_entry)

Powered by Google App Engine
This is Rietveld 408576698