Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 743773003: OOPIF: Data URLs are now rendered in the renderer that initiated the navigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index 3769ce204372a1535dae41139e1c18aa21f08723..7669ca9f9dd4633322a878efdfb2d2740f1d736f 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -270,10 +270,14 @@ class CONTENT_EXPORT RenderFrameHostImpl
// Load the specified URL; this is a shortcut for Navigate().
void NavigateToURL(const GURL& url);
- // Treat this prospective navigation as thought it originated from the
- // frame. Used, e.g., for a navigation request that originated from
- // a RemoteFrame.
- void OpenURL(const FrameHostMsg_OpenURL_Params& params);
+ // Treat this prospective navigation as though it originated from the frame.
+ // Used, e.g., for a navigation request that originated from a RemoteFrame.
+ // |source_site_instance| is the site instance of the frame that initiated the
nasko 2014/12/11 01:14:44 nit: s/site instance/SiteInstance/
lfg 2014/12/11 23:55:24 Done.
+ // navigation.
+ // TODO(creis): Remove this method and have RenderFrameProxyHost call
+ // RequestOpenURL with its FrameTreeNode.
+ void OpenURL(const FrameHostMsg_OpenURL_Params& params,
+ SiteInstance* source_site_instance);
// Stop the load in progress.
void Stop();

Powered by Google App Engine
This is Rietveld 408576698