Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 743773003: OOPIF: Data URLs are now rendered in the renderer that initiated the navigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 // function takes ownership of the provided message pointer. 263 // function takes ownership of the provided message pointer.
264 // 264 //
265 // If a cross-site request is in progress, we may be suspended while waiting 265 // If a cross-site request is in progress, we may be suspended while waiting
266 // for the onbeforeunload handler, so this function might buffer the message 266 // for the onbeforeunload handler, so this function might buffer the message
267 // rather than sending it. 267 // rather than sending it.
268 void Navigate(const FrameMsg_Navigate_Params& params); 268 void Navigate(const FrameMsg_Navigate_Params& params);
269 269
270 // Load the specified URL; this is a shortcut for Navigate(). 270 // Load the specified URL; this is a shortcut for Navigate().
271 void NavigateToURL(const GURL& url); 271 void NavigateToURL(const GURL& url);
272 272
273 // Treat this prospective navigation as thought it originated from the 273 // TODO(creis): Remove this method and have RenderFrameProxyHost call
Charlie Reis 2014/12/09 19:14:37 nit: Move TODO to the end of the comment (since th
lfg 2014/12/10 21:53:00 Done.
274 // frame. Used, e.g., for a navigation request that originated from 274 // RequestOpenURL with its FrameTreeNode.
275 // a RemoteFrame. 275 // Treat this prospective navigation as thought it originated from the frame.
Charlie Reis 2014/12/09 19:14:37 nit: thought -> though
lfg 2014/12/10 21:53:00 Done.
276 void OpenURL(const FrameHostMsg_OpenURL_Params& params); 276 // Used, e.g., for a navigation request that originated from a a RemoteFrame.
Charlie Reis 2014/12/09 19:14:37 nit: fix "a a"
lfg 2014/12/10 21:53:00 Done.
277 // |source_site_instance| is the site instance of the frame that initiated the
278 // navigation.
279 void OpenURL(const FrameHostMsg_OpenURL_Params& params,
280 SiteInstance* source_site_instance);
277 281
278 // Stop the load in progress. 282 // Stop the load in progress.
279 void Stop(); 283 void Stop();
280 284
281 // Returns whether navigation messages are currently suspended for this 285 // Returns whether navigation messages are currently suspended for this
282 // RenderFrameHost. Only true during a cross-site navigation, while waiting 286 // RenderFrameHost. Only true during a cross-site navigation, while waiting
283 // for the onbeforeunload handler. 287 // for the onbeforeunload handler.
284 bool are_navigations_suspended() const { return navigations_suspended_; } 288 bool are_navigations_suspended() const { return navigations_suspended_; }
285 289
286 // Suspends (or unsuspends) any navigation messages from being sent from this 290 // Suspends (or unsuspends) any navigation messages from being sent from this
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
609 613
610 // NOTE: This must be the last member. 614 // NOTE: This must be the last member.
611 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 615 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
612 616
613 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 617 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
614 }; 618 };
615 619
616 } // namespace content 620 } // namespace content
617 621
618 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 622 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698