components/cronet/android/url_request_adapter.h - Issue 743713002: Cronet Fix Channel Write after Close when request is canceled after success.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/url_request_adapter.h

Issue 743713002: Cronet Fix Channel Write after Close when request is canceled after success. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self review. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/CronetUrlTest.java ('K') | « components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java ('k') | components/cronet/android/url_request_adapter.cc » ('j') | components/cronet/android/url_request_adapter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/url_request_adapter.h

diff --git a/components/cronet/android/url_request_adapter.h b/components/cronet/android/url_request_adapter.h

index 56035eae50ff4a5909d6ed1139a62b4d17de1d78..f5f80127684aaa758e4c6c1b14ba2c6312553b18 100644

--- a/components/cronet/android/url_request_adapter.h

+++ b/components/cronet/android/url_request_adapter.h

@@ -17,7 +17,7 @@

#include "net/url_request/url_request.h"

namespace net {

-class GrowableIOBuffer;

+class IOBufferWithSize;

class HttpResponseHeaders;

class UploadDataStream;

struct RedirectInfo;

@@ -153,7 +153,7 @@ class URLRequestAdapter : public net::URLRequest::Delegate {

net::HttpRequestHeaders headers_;

scoped_ptr<net::URLRequest> url_request_;

scoped_ptr<net::UploadDataStream> upload_data_stream_;

- scoped_refptr<net::GrowableIOBuffer> read_buffer_;

+ scoped_refptr<net::IOBufferWithSize> read_buffer_;

int bytes_read_;

int total_bytes_read_;

int error_code_;