Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: components/cronet/android/test/mock_url_request_job_factory.cc

Issue 743713002: Cronet Fix Channel Write after Close when request is canceled after success. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Windows linker error. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/mock_url_request_job_factory.cc
diff --git a/components/cronet/android/test/mock_url_request_job_factory.cc b/components/cronet/android/test/mock_url_request_job_factory.cc
index 095f75131cab72af80fd410c178caad1424b1eae..aa36ebea59ff384d7048e09b0659c1a5d3286136 100644
--- a/components/cronet/android/test/mock_url_request_job_factory.cc
+++ b/components/cronet/android/test/mock_url_request_job_factory.cc
@@ -11,6 +11,7 @@
#include "base/threading/sequenced_worker_pool.h"
#include "jni/MockUrlRequestJobFactory_jni.h"
#include "net/test/url_request/url_request_failed_job.h"
+#include "net/test/url_request/url_request_mock_data_job.h"
#include "net/test/url_request/url_request_mock_http_job.h"
namespace cronet {
@@ -20,6 +21,7 @@ void AddUrlInterceptors(JNIEnv* env, jclass jcaller, jstring jtest_files_root) {
base::android::ConvertJavaStringToUTF8(env, jtest_files_root));
net::URLRequestMockHTTPJob::AddUrlHandler(
test_files_root, new base::SequencedWorkerPool(1, "Worker"));
+ net::URLRequestMockDataJob::AddUrlHandler();
net::URLRequestFailedJob::AddUrlHandler();
}
@@ -42,6 +44,16 @@ jstring GetMockUrlWithFailure(JNIEnv* jenv,
return base::android::ConvertUTF8ToJavaString(jenv, url.spec()).Release();
}
+jstring GetMockUrlForData(JNIEnv* jenv,
+ jclass jcaller,
+ jstring jdata,
+ jint jdata_repeat_count) {
+ std::string data(base::android::ConvertJavaStringToUTF8(jenv, jdata));
+ GURL url(net::URLRequestMockDataJob::GetMockHttpUrl(data,
+ jdata_repeat_count));
+ return base::android::ConvertUTF8ToJavaString(jenv, url.spec()).Release();
+}
+
bool RegisterMockUrlRequestJobFactory(JNIEnv* env) {
return RegisterNativesImpl(env);
}

Powered by Google App Engine
This is Rietveld 408576698