components/cronet/android/chromium_url_request.cc - Issue 743713002: Cronet Fix Channel Write after Close when request is canceled after success.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/chromium_url_request.cc

Issue 743713002: Cronet Fix Channel Write after Close when request is canceled after success. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Windows linker error. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/MockUrlRequestJobTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/chromium_url_request.cc

diff --git a/components/cronet/android/chromium_url_request.cc b/components/cronet/android/chromium_url_request.cc

index 239c024f9dfa5cee67176083af92e66f82cd2f0e..156c0636a80f86836190af808b2d6d1d7045e6c8 100644

--- a/components/cronet/android/chromium_url_request.cc

+++ b/components/cronet/android/chromium_url_request.cc

@@ -64,8 +64,8 @@ class JniURLRequestAdapterDelegate

cronet::Java_ChromiumUrlRequest_onResponseStarted(env, owner_);

}

- void OnBytesRead(URLRequestAdapter* request_adapter) override {

- int bytes_read = request_adapter->bytes_read();

+ void OnBytesRead(URLRequestAdapter* request_adapter,

+ int bytes_read) override {

if (bytes_read != 0) {

JNIEnv* env = base::android::AttachCurrentThread();

base::android::ScopedJavaLocalRef<jobject> java_buffer(

« no previous file with comments | « no previous file | components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/MockUrlRequestJobTest.java » ('j') | no next file with comments »