Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java

Issue 743713002: Cronet Fix Channel Write after Close when request is canceled after success. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Matt's comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java
index de41031af9d1b76722f750b22e2a7483ad5faeda..60e0e8d5804247474849f8d7eb54dc30a858856b 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/cronet_test_apk/TestHttpUrlRequestListener.java
@@ -30,6 +30,7 @@ public class TestHttpUrlRequestListener implements HttpUrlRequestListener {
public Exception mException;
public Map<String, List<String>> mResponseHeaders;
+ private ConditionVariable mStarted = new ConditionVariable();
private ConditionVariable mComplete = new ConditionVariable();
mmenke 2014/12/10 20:59:14 Make these two final?
mef 2014/12/10 23:23:35 Done.
public TestHttpUrlRequestListener() {
@@ -43,6 +44,7 @@ public class TestHttpUrlRequestListener implements HttpUrlRequestListener {
mHttpStatusCode = request.getHttpStatusCode();
mNegotiatedProtocol = request.getNegotiatedProtocol();
mHttpStatusText = request.getHttpStatusText();
+ mStarted.open();
}
@Override
@@ -62,8 +64,15 @@ public class TestHttpUrlRequestListener implements HttpUrlRequestListener {
mResponseAsString = new String(mResponseAsBytes);
mException = request.getException();
mComplete.open();
- Log.i(TAG, "****** Request Complete, status code is "
- + request.getHttpStatusCode());
+ Log.i(TAG, "****** Request Complete over " + mNegotiatedProtocol
+ + ", status code is " + mHttpStatusCode);
+ }
+
+ /**
+ * Blocks until the response starts.
+ */
+ public void blockForStart() {
+ mStarted.block();
}
/**

Powered by Google App Engine
This is Rietveld 408576698