Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Unified Diff: components/cronet/android/chromium_url_request.cc

Issue 743713002: Cronet Fix Channel Write after Close when request is canceled after success. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Matt's comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/chromium_url_request.cc
diff --git a/components/cronet/android/chromium_url_request.cc b/components/cronet/android/chromium_url_request.cc
index 239c024f9dfa5cee67176083af92e66f82cd2f0e..156c0636a80f86836190af808b2d6d1d7045e6c8 100644
--- a/components/cronet/android/chromium_url_request.cc
+++ b/components/cronet/android/chromium_url_request.cc
@@ -64,8 +64,8 @@ class JniURLRequestAdapterDelegate
cronet::Java_ChromiumUrlRequest_onResponseStarted(env, owner_);
}
- void OnBytesRead(URLRequestAdapter* request_adapter) override {
- int bytes_read = request_adapter->bytes_read();
+ void OnBytesRead(URLRequestAdapter* request_adapter,
+ int bytes_read) override {
if (bytes_read != 0) {
JNIEnv* env = base::android::AttachCurrentThread();
base::android::ScopedJavaLocalRef<jobject> java_buffer(

Powered by Google App Engine
This is Rietveld 408576698