Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: sky/engine/core/inspector/JavaScriptCallFrame.cpp

Issue 743673002: Fix debugger crash in Sky (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/bindings/core/v8/DebuggerScript.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/inspector/JavaScriptCallFrame.cpp
diff --git a/sky/engine/core/inspector/JavaScriptCallFrame.cpp b/sky/engine/core/inspector/JavaScriptCallFrame.cpp
index 126eff0074274277fe9ed0c239d3cb419ab1fd62..c4bca793b4e7b408670738c43c183514e503b73e 100644
--- a/sky/engine/core/inspector/JavaScriptCallFrame.cpp
+++ b/sky/engine/core/inspector/JavaScriptCallFrame.cpp
@@ -122,7 +122,9 @@ v8::Handle<v8::Value> JavaScriptCallFrame::scopeChain() const
int JavaScriptCallFrame::scopeType(int scopeIndex) const
{
- v8::Handle<v8::Array> scopeType = v8::Handle<v8::Array>::Cast(m_callFrame.newLocal(m_isolate)->Get(v8AtomicString(m_isolate, "scopeType")));
+ v8::Handle<v8::Object> callFrame = m_callFrame.newLocal(m_isolate);
+ v8::Handle<v8::Function> func = v8::Handle<v8::Function>::Cast(callFrame->Get(v8AtomicString(m_isolate, "scopeType")));
+ v8::Handle<v8::Array> scopeType = v8::Handle<v8::Array>::Cast(func->Call(callFrame, 0, 0));
return scopeType->Get(scopeIndex)->Int32Value();
}
« no previous file with comments | « sky/engine/bindings/core/v8/DebuggerScript.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698