Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 743653002: [ServiceWorker] support OPTIONS request for ServiceWorker [3/3 blink] (Closed)

Created:
6 years, 1 month ago by horo
Modified:
6 years, 1 month ago
Reviewers:
Mike West, yhirano
CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] support OPTIONS request for ServiceWorker [3/3 blink] Currently we can't handle OPTIONS request in the ServiceWorker. This check is done in content/browser/service_worker/service_worker_request_handler.cc. But we should support OPTIONS request except for CORS preflight request. [1/3] blink: https://codereview.chromium.org/738033002/ Set SkipServiceWorker flag for CORS preflight request. [2/3] chromium: https://codereview.chromium.org/716083003/ Remove IsMethodSupportedForServiceWorker check in service_worker_request_handler.cc [3/3] blink: https://codereview.chromium.org/743653002/ Cleanup and add update LayoutTest. BUG=434660 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185836

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Total comments: 3

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -29 lines) Patch
M LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html View 1 2 3 2 chunks +10 lines, -26 lines 0 comments Download
M Source/core/loader/DocumentThreadableLoader.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
horo
yhirano@ Could you please review this?
6 years, 1 month ago (2014-11-19 12:43:15 UTC) #2
yhirano
lgtm https://codereview.chromium.org/743653002/diff/60001/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html File LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html (right): https://codereview.chromium.org/743653002/diff/60001/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html#newcode84 LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html:84: .then(function(response){ please add a space after between ')' ...
6 years, 1 month ago (2014-11-21 03:44:51 UTC) #4
yhirano
https://codereview.chromium.org/743653002/diff/60001/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html File LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html (right): https://codereview.chromium.org/743653002/diff/60001/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html#newcode84 LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html:84: .then(function(response){ On 2014/11/21 03:44:51, yhirano wrote: > please add ...
6 years, 1 month ago (2014-11-21 03:51:45 UTC) #5
horo
Thank you! https://codereview.chromium.org/743653002/diff/60001/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html File LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html (right): https://codereview.chromium.org/743653002/diff/60001/LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html#newcode84 LayoutTests/http/tests/serviceworker/resources/fetch-request-xhr-iframe.html:84: .then(function(response){ On 2014/11/21 03:51:45, yhirano wrote: > ...
6 years, 1 month ago (2014-11-21 04:22:49 UTC) #6
horo
mkwst@ Could you please review this?
6 years, 1 month ago (2014-11-21 04:24:12 UTC) #8
Mike West
LGTM.
6 years, 1 month ago (2014-11-21 08:25:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/743653002/80001
6 years, 1 month ago (2014-11-22 02:56:17 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-22 04:08:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185836

Powered by Google App Engine
This is Rietveld 408576698