Switching to the correct desktop when a system modal dialog gets shown

Switching to the correct desktop when a system modal dialog gets shown

Instead of blindly hiding a window, this patch will check if the owner of the window is a system modal container. If so, switch users instead. 

BUG=318832
TEST=unittest (and visual)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235773

[Mr4D (OOO till 08-26), 2013-11-15 21:42:15]

Please have a look!

[sky, 2013-11-16 00:34:54]

https://codereview.chromium.org/74363004/diff/1/chrome/browser/ui/ash/multi_u...
File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
(right):

https://codereview.chromium.org/74363004/diff/1/chrome/browser/ui/ash/multi_u...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:476:
ash::internal::RootWindowController* controller =
Classes in internal namespaces shouldn't be used outside of the directory. So,
either RWC shouldn't be in internal or you shouldn't be using RWC. You should be
able to use GetChildById on the root.

https://codereview.chromium.org/74363004/diff/1/chrome/browser/ui/ash/multi_u...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:487: if
(owning_window)
Should this be a DCHECK? Otherwise you know 490 is going to hit?

I don't know your code enough to say if DCHECK is right here or not. Its very
likely that a system model dialog has no owner.

[Mr4D (OOO till 08-26), 2013-11-16 00:54:27]

Addressed! Please have another look!

https://codereview.chromium.org/74363004/diff/1/chrome/browser/ui/ash/multi_u...
File chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc
(right):

https://codereview.chromium.org/74363004/diff/1/chrome/browser/ui/ash/multi_u...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:476:
ash::internal::RootWindowController* controller =
On 2013/11/16 00:34:55, sky wrote:
> Classes in internal namespaces shouldn't be used outside of the directory. So,
> either RWC shouldn't be in internal or you shouldn't be using RWC. You should
be
> able to use GetChildById on the root.

Done.

https://codereview.chromium.org/74363004/diff/1/chrome/browser/ui/ash/multi_u...
chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc:487: if
(owning_window)
On 2013/11/16 00:34:55, sky wrote:
> Should this be a DCHECK? Otherwise you know 490 is going to hit?
> 
> I don't know your code enough to say if DCHECK is right here or not. Its very
> likely that a system model dialog has no owner.

Done.

[sky, 2013-11-18 14:25:58]

LGTM

[commit-bot: I haz the power, 2013-11-18 15:10:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/74363004/260001

[commit-bot: I haz the power, 2013-11-18 18:42:48]

Change committed as 235773